TokisanGames / Terrain3D

A high performance, editable terrain system for Godot 4.
MIT License
2.21k stars 131 forks source link

Renaming of Layer properties #163

Closed tredokiller closed 1 year ago

tredokiller commented 1 year ago

In my opinion, something is wrong with the naming of layers "collision_layers" and "render_layers"

In the plugin, it looks like this: image

But in other default nodes, it looks like this: image

Because of this, I can`t use checking by layer, because the name of the variable is different. image

I think it would be better to rename it to "collision_layer" and "render_layer" like in other nodes

TokisanGames commented 1 year ago

It is Godot that is inconsistent.

There's also

The questions I ask are:

I'm considering.

For now you can query if it is a terrain

if collider is Terrain3D:
    ...
TokisanGames commented 1 year ago

I think we will match Godot's inconsistency. render_layers with VisualInstance.layers, and collision_layer with CollisionObject.collision_layer. If they fix their physics name to match everything else, we will change it back with them.