Doubt about Masked Metric's init

[LucaButera]

In tsl.metric.torch.metric_base.MaskedMetric.__init__ we have the following snippet

if metric_fn is None:
    self.metric_fn = None
else:
    self.metric_fn = partial(metric_fn, **metric_fn_kwargs)

Wouldn't this lead to a behavior in which we have an error thrown for passing metric_fn=None only upon computing the metric instead that having it thrown upon class construction? Is this a desired behavior?

[marshka]

Hi Luca,

yes, you're right, the metric function shouldn't be optional. We'll change this soon, thanks!