Open LucaButera opened 1 year ago
https://github.com/TorchSpatiotemporal/tsl/blob/9a5cee97123cb904763e922f3825ac236e0b6dc9/tsl/metrics/torch/pinball_loss.py#L30
In pinball_loss the PyTorch Lightning Metric deprecated parameter compute_on_step is used. See Lightning-AI/torchmetrics#789
compute_on_step
It should be removed accordingly.
In general, it may make sense to update compatibility to Lightning 2.0. This issue serves as a reminder for discussion on such thing.
https://github.com/TorchSpatiotemporal/tsl/blob/9a5cee97123cb904763e922f3825ac236e0b6dc9/tsl/metrics/torch/pinball_loss.py#L30
In pinball_loss the PyTorch Lightning Metric deprecated parameter
compute_on_stepis used. See Lightning-AI/torchmetrics#789It should be removed accordingly.
In general, it may make sense to update compatibility to Lightning 2.0. This issue serves as a reminder for discussion on such thing.