search

TorchSpatiotemporal / tsl

tsl: a PyTorch library for processing spatiotemporal data.
https://torch-spatiotemporal.readthedocs.io/
MIT License
236 stars 22 forks source link

SpatioTemporalDataset.from_dataset does not accept the transform parameter. #30

Open LucaButera opened 8 months ago

LucaButera commented 8 months ago

Issue: The convenience method SpatioTemporalDataset.from_dataset does not accept any transform parameter, so it either has to be set manually after instantiation or the user must use the standard constructor.

Proposed solution: Add transform as parameter to from_dataset or move to a kwargs based implementation.

I can implement this based on an agreed upon solution.

marshka commented 2 months ago

Adding the parameter sounds good to me, I think having only explicit parameters in that method makes all more transparent. More than happy if you could contribute in this regard! :)