search

Touseefelahi / GigeVision

Simple GigeVision implementation, GVSP, GVCP protocol implemented
103 stars 31 forks source link

C#7.3 Compatibility, .Net Standart 2.0 #106

Open blauertee opened 3 months ago

blauertee commented 3 months ago

This is definetly not ready to be merged.

Target Frameworks have to be Edited and I'm not sure whether you really want to give up on the syntactic shugar of C#9.0.

Also all methods taking byte[] as an argument don't accept Span<byte> in C#7.3 so I just lazily inserted ToArray() everywhere, not sure what this does under the hood but it could lead to serous performance issues.

But I thought this may be useful for someone anyway. :)

Touseefelahi commented 3 months ago

Thank you for the PR. Yes, we need to fix ToArray() for the performance issue. And again it will require some testing before the merge. I am not sure when can we test this.