Touseefelahi / GigeVision

Simple GigeVision implementation, GVSP, GVCP protocol implemented
92 stars 29 forks source link

When using ForceIP, why does the subnet mask need to be 255.255.255.0? #107

Closed HorPaella closed 1 week ago

HorPaella commented 3 weeks ago

When using ForceIP, it will not work unless the computer's subnet mask is 255.255.255.0. Why are other subnet masks not permitted?

GigeVision.Core/Services/Gvcp.cs ForceIPAsync GigeVision.Core/Services/OtherServices/NetworkService.cs GetAllInterfaces

Touseefelahi commented 3 weeks ago

yes, it should be fixed, it is not supposed to be like this

CosbyBs86 commented 1 week ago

Having the IDE opened for other changes that @Touseefelahi already applied to master, I did the fix (https://github.com/Touseefelahi/GigeVision/pull/114).