search

Touseefelahi / GigeVision

Simple GigeVision implementation, GVSP, GVCP protocol implemented
97 stars 31 forks source link

Supporting the Max and Min value for FLOAT parameters. Supporting the Min and Max value from register and not only from formula #110

Closed CosbyBs86 closed 1 month ago

CosbyBs86 commented 1 month ago

Even for generic and float parameter the system should support the Max and Min values of the parameter. The PMin and PMax should also be able to support registers and not only formulas

CosbyBs86 commented 1 month ago

Hello @Touseefelahi can you have a look on this PR? many thanks Please let me know if I can help you further. I still have a couple of changes to submit but I would like to go step by step avoiding to waste your time.

Touseefelahi commented 1 month ago

Hello @CosbyBs86, Thank you for the PR, I really appreciate the effort.

CosbyBs86 commented 1 month ago

Thank you @Touseefelahi for approving the PR. It is a pleasure to contribute in such library. I have two more PR and then I finished for the moment. I swear :) I’ll submit the PR tomorrow. Have a good Sunday and let me know if I can help you further