Touseefelahi / GigeVision

Simple GigeVision implementation, GVSP, GVCP protocol implemented
97 stars 31 forks source link

Keeping sent a package during the stream for firewall hole punching #117

Closed CosbyBs86 closed 1 month ago

CosbyBs86 commented 1 month ago

I added the keep alive hole punching (default 30 seconds). It is not possible to create a dedicated thread for this operation because the socket is bound in Receiver() method and it might collide with the blocking Receive operation. I added a check in the receiver loop. If the time between the last keep alive and the current time is >= with the defined timeout (30 seconds as default) a package is sent.

CosbyBs86 commented 1 month ago

@Touseefelahi here we go for the keep alive firewall hole punching.

CosbyBs86 commented 1 month ago

Thank you @Touseefelahi Do you have any chance to make a release with all those changes and publish it as new nuget package?

Touseefelahi commented 1 month ago

You're welcome @CosbyBs86 If you are done with your changes then I'll do it by the end of this week

CosbyBs86 commented 1 month ago

Yes @Touseefelahi I finished all the changes. For me you can go with the new release.

Touseefelahi commented 1 month ago

@CosbyBs86 hey, I just updated the Nuget package. Thank you for your contribution. Can you share your contact info, email or Whatsapp number?

CosbyBs86 commented 1 month ago

@Touseefelahi if you share your email I'll send my contacts. I don't want to publish them here ;)

Touseefelahi commented 1 month ago

@CosbyBs86 sure, contact me at touseefelahi@ymail.com