search

TownyAdvanced / TownyResources

Adds value to towns, by giving each one a unique set of automatically-generated resources.
Other
29 stars 16 forks source link

[Feature Request] Add MMOItems support (Mi) #102

Closed NeotenySS closed 1 year ago

NeotenySS commented 1 year ago

Somehow ItemAdder support was added. Is it possible to make the same support for the MMOItems plugin?

Spigot (plugin) : https://www.spigotmc.org/resources/30-off-mmoitems-premium.39267/

MMOItems API: https://gitlab.com/phoenix-dvpmt/mmoitems/-/wikis/Main%20API%20Features

NeotenySS commented 1 year ago

@LlmDl Sorry if I interrupt, the plugin has not been released for a long time, but there are preliminary builds, perhaps this Issue will be decisive and allow to make the release 2.0.1 or 2.1.0

LlmDl commented 1 year ago

The latest builds are available on here as pre-releases: https://github.com/TownyAdvanced/TownyResources/releases

NeotenySS commented 1 year ago

The latest builds are available on here as pre-releases: https://github.com/TownyAdvanced/TownyResources/releases

Do they have support for MMOItems? I didn't see any comits in changelogs. Maybe I wasn't watching it right (

LlmDl commented 1 year ago

Those builds don't have MMOItems support.

NeotenySS commented 1 year ago

Can add support please? Or should I close the issue?

LlmDl commented 1 year ago

You can leave it open, but I'm not really being paid well for the time I put into all the plugins, so a plugin like TownyResources does get set to the side in favour of Towny, SiegeWar, and the sponsor plugins. It might happen given enough time or another interested developer makes a good pull request.

NeotenySS commented 1 year ago

Understood, thank you for your reply, I will wait

LlmDl commented 1 year ago

So I've got something working, but I see that a player can be passed into an item upon creation, making the item leveled to that player.

Are we wanting base-items or player-leveled-items?

NeotenySS commented 1 year ago

Items that will be given to the player are resources, they are properly do not have a level. Items such as armor, weapons, accessories, they have a level. But the TownyResources plugin only targets resources. You're a tough guy! Thanks ❤ @LlmDl

LlmDl commented 1 year ago

I have it coded to accept all of the MMOItems, but I could not get the player-leveling to work so that's being left out.

NeotenySS commented 1 year ago

I have it coded to accept all of the MMOItems, but I could not get the player-leveling to work so that's being left out.

Well, it's not terrible, I think the owners of the servers will find a way to solve, creating separate resources that could be given to certain levels. Thank you! And when will be 2.4?

LlmDl commented 1 year ago

Probably not too long now, I'll see if I want to add anything else first.

NeotenySS commented 1 year ago

👌 Thanks! I can close issue?

LlmDl commented 1 year ago

It will close automatically when the PR is merged.