Tracardi / tracardi

TRACARDI is a new HOME for your customer data. TRACARDI is an Composable API-first solution for any company that need inexpensive CDP to intergrate with.
https://www.tracardi.com
Other
501 stars 92 forks source link

Plugin that converts string to date #803 #825

Closed Kaushik-Iyer closed 11 months ago

Kaushik-Iyer commented 11 months ago

Solves Issue #803

This PR adds a plugin that converts given string to a given date format. I also tried testing it through a pytest file and I got a correct assertion, but I am still not sure if all my code is right

Please following this checklist to help us incorporate your contribution quickly and easily:

CLAassistant commented 11 months ago

CLA assistant check
All committers have signed the CLA.

CLAassistant commented 11 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

atompie commented 11 months ago

@Kaushik-Iyer Thank you for you PR. Could you use this library to make sure that broader type of data strings are accepted?

https://dateparser.readthedocs.io/en/latest/ Also there is a Pending — Contributor License Agreement is not signed yet. Could you click details and sign the CLA.

Kaushik-Iyer commented 11 months ago

@atompie please check the recent commits. I have implemented dateparser module, and it does not need specifying any input date format. I have made converted date to be year month date for uniformity.

this is a example test case that runs currently

image

atompie commented 11 months ago

@Kaushik-Iyer THe changes are ok. The last thing I need is a license/cla . Contributor License Agreement is not signed yet. Could you click details and sign the CLA. Without this I can not merge as I do not have your permission to do so.

Kaushik-Iyer commented 11 months ago

@atompie is it showing as signed now?

atompie commented 11 months ago

@Kaushik-Iyer Unfortunately not. Have you done this. You have to be logged in with your github account.

https://github.com/Tracardi/tracardi/assets/16271564/5c38a20a-6ab8-43b6-b87f-9fae82f32f1e

Kaushik-Iyer commented 11 months ago

@atompie done I signed it now