Closed Kaushik-Iyer closed 11 months ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
@Kaushik-Iyer Thank you for you PR. Could you use this library to make sure that broader type of data strings are accepted?
https://dateparser.readthedocs.io/en/latest/ Also there is a Pending — Contributor License Agreement is not signed yet. Could you click details and sign the CLA.
@atompie please check the recent commits. I have implemented dateparser module, and it does not need specifying any input date format. I have made converted date to be year month date for uniformity.
this is a example test case that runs currently
@Kaushik-Iyer THe changes are ok. The last thing I need is a license/cla . Contributor License Agreement is not signed yet. Could you click details and sign the CLA. Without this I can not merge as I do not have your permission to do so.
@atompie is it showing as signed now?
@Kaushik-Iyer Unfortunately not. Have you done this. You have to be logged in with your github account.
https://github.com/Tracardi/tracardi/assets/16271564/5c38a20a-6ab8-43b6-b87f-9fae82f32f1e
@atompie done I signed it now
Solves Issue #803
This PR adds a plugin that converts given string to a given date format. I also tried testing it through a pytest file and I got a correct assertion, but I am still not sure if all my code is right
Please following this checklist to help us incorporate your contribution quickly and easily:
[X] Give the same name to the pull request as the name of ticket
[X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[X] Test your code thoroughly before PR.
[X] I hereby declare this contribution to be licenced under the MIT license