TradeMaster-NTU / PRUDEX-Compass

Official implementation of PRUDEX-Compass
MIT License
36 stars 18 forks source link

Logging losses and reward with Tensorboard #23

Open DeepAnonymous opened 1 year ago

DeepAnonymous commented 1 year ago

Hi,

I tried to log policy and critic losses as well as reward using Tensorboard. I run training using default setting with sz50.

I noticed that critic losses keep increasing. Does this even make sense?

tensorboard

I wonder is there any issue with the code regarding critic losses, could you please have a check/comment on this.

Thank you.

DeepAnonymous commented 1 year ago

Also, could you please give a short comment about feedback_type, I am confused with 0,1,2 options.

For me, only feedback_type = 0 makes sense, because it takes ensemble-wise index std_Q_critic_list[en_index], instead of std_Q_critic_list[0] as feedback_type = 1

qinmoelei commented 1 year ago

In RL, I don't think we should pay too much attention in loss of critic actor or anything else. The key indicator is the reward sum. For the deedback_type, I think that is from the ablation study.