search

Tramac / Fast-SCNN-pytorch

A PyTorch Implementation of Fast-SCNN: Fast Semantic Segmentation Network
Apache License 2.0
382 stars 93 forks source link

class balancing option is not accessible #11

Open priancho opened 5 years ago

priancho commented 5 years ago

Description

In train.py, MixSoftmaxCrossEntropyOHEMLoss() method (https://github.com/Tramac/Fast-SCNN-pytorch/blob/master/train.py#L103) doesn't allow to control use_weight option, which is True by default.

I think that it should be False by default because this class balancing weights should be applied only to cityscapes dataset. It might be better to provide class balancing weights from cmd-args or from data_loader class (e.g., data_loader/cityscapes.py).

Tramac commented 5 years ago

Yeah, thanks for your advice.