TravelPouch / travelpouch

2 stars 2 forks source link

fix: close issue by updating package name to com.github.se.travelpouch #6

Closed appellet closed 2 weeks ago

appellet commented 2 weeks ago

This pull request addresses the issue of updating the package name from com.android.sample to com.github.se.travelpouch. This change ensure to be consistent with the bootcamp and the conventional package name.

Related Issue: Closes #4

ArthurChalard commented 2 weeks ago

Hey, This is a great idea. Maybe you should change the package name at the top of the files and remove the old directories to avoid duplication.

appellet commented 2 weeks ago

Hey, This is a great idea. Maybe you should change the package name at the top of the files and remove the old directories to avoid duplication.

Done, thank you !

ArthurChalard commented 2 weeks ago

Great, you avoided the duplication, but the packages at the top of the files are still the old ones

appellet commented 2 weeks ago

Great, you avoided the duplication, but the packages at the top of the files are still the old ones

Done, I changed the package for all relevant files. Thanks for reminding me !

sonarcloud[bot] commented 2 weeks ago

Quality Gate Failed Quality Gate failed

Failed conditions
48.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud