davepacheco
commented
7 years ago Proposed fix: https://cr.joyent.us/2484
Prior to the proposed change, ./tools/publish did this when I ran it to publish 1.2.0:
$ ./tools/publish
Checking for local copy of Manta tools ... okay.
Loading version number ... 1.2.0.
Checking for build/ia32/mdb_v8.so ... done.
Checking for release tag on build/ia32/mdb_v8.so ... mdb: failed to determine V8 version: unknown symbol name
"version:
dev"
publish: does not appear to be a release build (tag "version: dev")That error message is coming from my own mdbrc:
$ cat ~/.mdbrc
::load /home/dap/mdb_v8/build/ia32/mdb_v8.soWith the fix in place from patchset 1, making no other changes to the binary or anything, this works as expected:
$ ./tools/publish -l
Checking for local copy of Manta tools ... okay.
Loading version number ... 1.2.0.
Checking for build/ia32/mdb_v8.so ... done.
Checking for release tag on build/ia32/mdb_v8.so ... "release"
Checking for build/amd64/mdb_v8.so ... done.
Checking for release tag on build/amd64/mdb_v8.so ... "release"
Creating git tag "v1.2.0" ... fatal: tag 'v1.2.0' already exists
Failed to apply tag. Continue? y
Listing upstream versions ... done.
Checking whether 1.2.0 already exists ... no
...2.0/mdb_v8_ia32.so [===========================>] 100% 253.45KB
....0/mdb_v8_amd64.so [===========================>] 100% 335.19KB
/Joyent_Dev/public/mdb_v8/latest 33B
Done.
Suggested next steps:
- push new tag using "git push --tags"
- make "clean" to avoid re-publishing release bits
- update "version" file for next development version
- commit that change and push it upstream
Automated use of mdb (as in the publish script) should probably use
-Sto disable loading the mdbrc file. (It's probably somewhat dubious for me to have an mdbrc file that sometimes produces errors, which is the problem in this case. However, very few people use this at all, and it seems likely that anything people would put in here (e.g., default output format changes) would break something that's trying to parse mdb's output.)