Tronald
commented
2 months ago Issue identified. Two simultaneous things are happening at once that need addressing.
Shallow Transit Meeus Issue. KNOWN ISSUE. Down All Day Trigger should be set to -0.8333, not 0, with a check at Solar Noon, not at user-specified altitude, for greater accuracy.
A NoSet / NoRise safety check will be added to handle part 1 and set the condition to "up or down all day" if the issue's condition is met. The math delta is significant during shallow transit (could be up to an hour), but this is the best solution for the use cases of this library (which is intended for applications prioritizing efficiency over precision). Real-world observer will, in most instances, have no concern if the output is "up or down all day" when the sun is hung near -0.8333 degrees in altitude. During shallow transition. Moreover, this issue would exhibit on rare occurrences, possibly one day a year in select circumpolar regions.
Documentation will need to be updated to ensure precision and limitation is understood.
Fix should be available in next couple days.
Jan32
Describe the bug Horizon transition causing confusion in circumpolar region, causing CoordinateSharp to think sun is DownAllDay when it is up all day.
To Reproduce Please provide a reproducible code example if able.
Expected behavior June / July should not have DownAllDay events. These should be up all day events. Issue only occurs when time of day < 12:00
Environment (please complete the following information):
Additional context Dissect sun condition logic and determine trigger. Push emergency patch.