search

TrueBitFoundation / truebit-toolchain

Utility for preparing Truebit tasks
MIT License
8 stars 3 forks source link

Add Docker & CI Example #1

Closed OR13 closed 6 years ago

OR13 commented 6 years ago

These changes support a macOS based setup, a docker based setup built from truebit controlled submodules, and travis ci tests for the docker image based toolchain.

hswick commented 6 years ago

Took a quick look, a couple things.

I'm seeing this in the README 

this is broken, the output from docker is different then local.

local works, docker does not.

this is only an issue with emcc

Is this still the case?

Also could you move the docker instructions above the MacOS ones.

And you can delete webasm-solidity from the submodules, you shouldnt need it.

OR13 commented 6 years ago

yep, I should have updated that, and I agree about moving the docker instructions up a level.

good feedback, i will implement.

hswick commented 6 years ago

Looks good, contains all the changes I asked for. Restarted the travis build because it couldnt download the dependencies for some reason.