Unable to parse path with space

Turistforeningen / node-s3-uploader

Flexible and efficient resize, rename, and upload images to Amazon S3 disk storage. Uses the official AWS Node SDK for transfer, and ImageMagick for image processing. Support for multiple image versions targets.

https://www.npmjs.com/package/s3-uploader

MIT License

241 stars 54 forks source link

Unable to parse path with space #108

Open hoodsy opened 8 years ago

hoodsy commented 8 years ago

Steps to reproduce

Upload a file with a space in the path, e.g. T/altright kreiger.png

Expected behaviour

The space in the path is accounted for, and the image is correctly found.

Actual behaviour

I can escape the space, like so: T/altright\ kreiger.png but then the path isn't correctly found: Error: ENOENT: no such file or directory,

@Starefossen

anthonyringoet commented 8 years ago

Can you provide info about your environment?

Operating system (Mac, Linux, Windows)
Node.js version (node --version)
ImageMagick version (identify -version)
s3-uploader version

webdevian commented 7 years ago

This happens for me, it throws an error with no stacktrace with

MacOS v10.12.4 
Node v6.10.2
ImageMagick 7.0.5-4 Q16 x86_64 2017-03-25
s3-uploader 2.0.3

I got around it by renaming files with encodeURIComponent() first, but it would be nice for the plugin to handle it.