search

TutteInstitute / fast_hdbscan

A fast multi-core implementation of HDBSCAN for low dimensional Euclidean spaces
BSD 2-Clause "Simplified" License
78 stars 8 forks source link

Trigger tests when a PR is submitted #7

Closed gclendenning closed 1 year ago

gclendenning commented 1 year ago

Currently only looks for PRs to the main branch but can be added for other branches. Also ignores updates to docs/README. The test results should show up in the PR discussion as well

lmcinnes commented 1 year ago

Coveralls is breaking now? I find that odd. Any ideas?

gclendenning commented 1 year ago

It's strange because it worked 5 minutes before on the PR to my fork. I submitted the PR to this repo and the tests automatically ran (which I don't think they should have based on the existing pipeline?). It seems like coveralls is having issues (https://github.com/lemurheavy/coveralls-public/issues/1710) but all the examples I can find are with github actions. There is this potential workaround but not sure if it will work. Do you know if there are already existing pipelines associated with the repo?

gclendenning commented 1 year ago

Looking at previous PRs it doesn't seem like any test suites ran automatically. I wonder if coveralls was complaining because it was running against the same commit message?

lmcinnes commented 1 year ago

I admit to not really knowing the issues here; I kind of cargo-culted together stuff like coveralls, and have very little understanding of it all. I don't recall coveralls complaining about the same commit message before though.

lmcinnes commented 1 year ago

Let's just merge for now and sort out coveralls later ...