Add namespace "Release.Namespace"

Twingate / helm-charts

Official Twingate Helm Charts

MIT License

12 stars 13 forks source link

Add namespace "Release.Namespace" #19

Closed LisaFournet8 closed 1 year ago

LisaFournet8 commented 1 year ago

Hi,

Is it possible to add the metadata namespace: {{ .Release.Namespace }} in all the resources?

We are deploying using Skaffold/Cloud Deploy, and it cannot deploy to a specific namespace without it. It is a quite standard way to define the namespace in Helm charts.

Thanks!

chenbishop commented 1 year ago

@LisaFournet8 @ekampf @bertekintw

Pull request created https://github.com/Twingate/helm-charts/pull/21

romankor commented 1 year ago

namespace is not something that is added to any helm chart see here : https://github.com/helm/helm/issues/5465#issuecomment-473942223 you can provide --namespace to any helm chart deployment

LisaFournet8 commented 1 year ago

Not when you're not deploying with Helm. We're using Skaffold and Google Cloud Deploy and there is no such flag. What I see in https://github.com/helm/helm/issues/5465 is that there is disagreement. I guess Google doesn't follow the best practice defined by Helm. Well if you guys don't want to make this change we'll just fork the chart

ekampf commented 1 year ago

Hey @LisaFournet8 I have dealt with Skaffold nd Google Cloud Deploy much but few notes re this issue:

It is the Helm best practice to not include namespace in the template and count on Helm's --namespace to take care of it (there's a discussion here)
There was an issue with Skaffold\Google Cloud Deploy regarding this (here) and it seems to have been resolved with this fix.

Is it still an issue for you?

LisaFournet8 commented 1 year ago

Hi @ekampf Thanks for checking. I haven't retried but I will (probably in a few weeks). It does look like they fixed it!