Better support for namespaces

Twingate / helm-charts

Official Twingate Helm Charts

MIT License

11 stars 12 forks source link

Better support for namespaces #21

Closed chenbishop closed 1 year ago

chenbishop commented 1 year ago

What this PR does / why we need it:

Which issue this PR fixes if any

Resolves #19

Special notes for your reviewer:

Adds {{ .Release.Namespace }} to deployment and secret

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] Chart Version bumped
[ ] Variables are documented in the README.md

ekampf commented 1 year ago

@chenbishop I'm closing this PR per @romankor 's comment and this clarification from the helm team on a similar issue

ekampf commented 1 year ago

After more discussions we decided to support this as its not breaking existing helm --namespace behavior. However I want to merge the unit tests PR #22 first and add unit tests here