Fix golden tests to be stable when chart version changes - Githubissues

Twingate / helm-charts

Official Twingate Helm Charts

MIT License

11 stars 12 forks source link

Fix golden tests to be stable when chart version changes #37

Closed ekampf closed 9 months ago

ekampf commented 9 months ago

What this PR does / why we need it:

Make our helm chart's golden tests less of a hassle:

We're using .Chart.Version value in our template - specifically we're using the cn.name helper:

{{- printf "%s-%s" .Chart.Name .Chart.Version | replace "+" "_" | trunc 63 | trimSuffix "-" -}}

Since the version value changes on (almost) every PR, any chart change will trigger all the golden test snapshots being updated.
What this fix does is set cn.name value to a specific const value during tests so that snapshots wont change on version change - https://github.com/Twingate/helm-charts/pull/37/files#diff-41512ec9e324e19e492871c5fe0d33e6a2506438dc49c2a83f51f9edbc663804

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Chart Version bumped
[x] Variables are documented in the README.md