TypeTogether / Playwrite

Sensei primary repository.
SIL Open Font License 1.1
93 stars 3 forks source link

`Lcaron`, `lcaron`, `dcaron`, should use the alternate caron #12

Closed vv-monsalve closed 10 months ago

vv-monsalve commented 11 months ago
Screen Shot 2023-08-28 at 19 43 40
josescaglione commented 11 months ago

no @vv-monsalve , the models we are following for Czechia and Slovakia require a two-stroke caron. It is a special (alternate) design as well

vv-monsalve commented 11 months ago

I see. Nevertheless, it's currently encoded to the main version of the glyph (013D and 012E) and not as an alternate.

Given the fonts can be used in other scenarios different from the intended (in this case, used for other purposes different from teaching), do you think this shape can be treated as an alternate? Or at least include compound glyphs with the standard alternate to make them available for other users/uses?

josescaglione commented 10 months ago

right, that is the shape those glyphs should look like in Czechia and Slovakia. When/if we find a model that requires a single line caron we will have to create it and add as a local or regional variant.

Please let me know if you need me to clarify.

vv-monsalve commented 10 months ago

When/if we find a model that requires a single line caron we will have to create it and add as a local or regional variant.

I would advocate for the opposite. Taking into consideration that fonts can (and will) be used by standard users apart from the educators, to include the single line caron (ideally as the default) and then make the Czechia and Slovakia model an alternate as a local or regional variant, making it the default only for those models.

josescaglione commented 10 months ago

Please clarify:

Do you want us to have a single line caron.alt in all of the fonts for countries and languages that do not use a caron at all

but A two-line caron.alt for the families for Czechia and Slovakia, the only countries that require a caron

I would normally deal with this at a stylistic set level. In reality, all of the use for the caron will happen in those two countries.

josescaglione commented 10 months ago

Sorry, just to clarify. The single line caron shape is in the font file already, this is just a matter of access to it we are discussing

vv-monsalve commented 10 months ago

this is just a matter of access to it we are discussing

Indeed. After pulling the latest files in the lang-build branch at commit 38897c5c and searching for the Lcaron lcaron and dcaron glyphs in the glyphs source file, the composite glyphs mapped to the 013D, 013E and 010F are using the two-lines caron.

Screen Shot 2023-09-05 at 10 54 28


The caroncomb.alt_locl does exist but currently is not used by any composite glyph.

The idea would be to make the single-line caron the default shape so that any user (apart from teachers) using the font for any other purpose (beyond teaching) would receive the "standard" or expected single-line caron. And making the two-lines caron a localized version for Czechia and Slovakia.

E.g. ARG model

Screen Shot 2023-09-05 at 10 50 46
vv-monsalve commented 10 months ago

Otoh, for the CZE and SVK models using the two-line caron, some possible glyph combinations (according to Context of Diacritics) need to be solved.

SVK model

Playpen-SVK-text-proof

CZE model

Playpen-CZE-text-proof
vv-monsalve commented 10 months ago

This looks ok for the most of the fonts at commit 1b4d055. However, looks like is not working for the SVK model, where the two-lines caron is expected as default.

@josescaglione please confirm everything is as intended.

ARG model

Screen Shot 2023-09-18 at 20 58 21

CZE model

Screen Shot 2023-09-18 at 21 02 39

SVK model

Screen Shot 2023-09-18 at 21 06 54
casasin commented 10 months ago

SVK should be fixed at 23d4a217

vv-monsalve commented 10 months ago

SVK is solved in 23d4a217f

Playpen-SVK-23d4a217f