TypeTogether / Playwrite

Sensei primary repository.
SIL Open Font License 1.1
130 stars 5 forks source link

Kerning #14

Open vv-monsalve opened 1 year ago

vv-monsalve commented 1 year ago

Please give kerning an overall revision and ensure the most common cases are covered. E.g. Yo Po LY LT among others

Screen Shot 2023-08-28 at 20 15 21 Screen Shot 2023-08-28 at 19 54 14
vv-monsalve commented 1 year ago

Playwrite Austria

Screen Shot 2023-11-15 at 0 00 01
vv-monsalve commented 9 months ago

@josescaglione, the following are the main findings after reviewing the basic kerning pairs for the 20 Countries of the Batch 1 to be published.

Please review the following:

You can see all the Batch-1 fonts images here: Playwrite-Batch1-kerning-rev-cc1f569-mid-res-jpg.zip . Find below som examples

Playwrite Indonesia

PW-ID

Playwrite Mexico

PW-MX

Playwrite Vietnam

PW-VN
josescaglione commented 8 months ago

NOTE ABOUT KERNING

This font contains a very large number of alternate shapes for each letter. As a result, it was decided to build compound glyphs on the fly. The process was very successful as it maintained the amount of characters manageable but a downside of this decision is the inability of adding kerning exceptions, at least in the current stage of development.

Kerning pairs were added in such a way that they avoid clashing of certain accented characters. Example below: WhatsApp Image 2024-04-03 at 11 21 47 WhatsApp Image 2024-04-03 at 11 23 53

vv-monsalve commented 8 months ago

Closing this issue with the above note.

vv-monsalve commented 7 months ago

When the latest fonts on the lang-build at commit bf2de62 are compared with the previous ones at commit cc1f569, there are no visible kern changes.

vv-monsalve commented 6 months ago

I'll collect the reports we receive here so they can be revised on further font versions.

Playwrite PL PR

josescaglione commented 5 months ago

Kerning "Ty"

Was able to check and correct all models except those that use y.cnt and a non connecting T. In those cases the pair is unnecessary: AR BR CA CO DE_GRUND HR HR_LIJEVA SK TZ US_MOD

Screen Shot 2024-06-10 at 14 54 19
josescaglione commented 5 months ago

added positive kerning between at and .cnt glyphs

Checked all models. This changes affects: AR AU_QLD AU_VIC BE_VLG BE_WAL BR CA CL CO CU CZ DE_LA DE_SAS ES ES_DECO FR_TRAD ID IN IT_TRAD MX NL PE PL PT RO SK TZ US_MOD US_TRAD

Screen Shot 2024-06-10 at 14 52 53 Screen Shot 2024-06-10 at 14 52 34
josescaglione commented 5 months ago

Added positive kerning between period and r.ful and e.ful to avoid a collision. Checked ALL models. This affects all pairs with an entry stroke on baseline grouped in e.ful and r.ful

Screen Shot 2024-06-10 at 15 09 52
josescaglione commented 5 months ago

Added positive kerning to pairs with r.ful and e.ful and related groups. This issue affects a few models that contain print capitals in combination with full cursive lower cases. For example ES, IN and ZA

Screenshot 2024-06-12 at 07 23 39
vv-monsalve commented 1 month ago

Kerning "Ty"

Was able to check and correct all models except those that use y.cnt and a non connecting T. In those cases the pair is unnecessary: AR BR CA CO DE_GRUND HR HR_LIJEVA SK TZ US_MOD

Ty kerning looks unmodified on fonts in Fixes branch at commit 3608fc Automated rebuild

Screenshot 2024-10-31 at 15 52 32
vv-monsalve commented 1 month ago

Kerning "@n" added positive kerning between at and .cnt glyphs Checked all models. This changes affects: AR AU_QLD AU_VIC BE_VLG BE_WAL BR CA CL CO CU CZ DE_LA DE_SAS ES ES_DECO FR_TRAD ID IN IT_TRAD MX NL PE PL PT RO SK TZ US_MOD US_TRAD

Confirmed it is working on fonts in Fixes branch at commit 3608fc Automated rebuild

vv-monsalve commented 1 month ago

kerning pairs ".r" ".e" Added positive kerning between period and r.ful and e.ful to avoid a collision. Checked ALL models. This affects all pairs with an entry stroke on baseline grouped in e.ful and r.ful

Confirmed it is working on fonts in Fixes branch at commit 3608fc Automated rebuild

vv-monsalve commented 1 month ago

Fix kerning C- Glyphs with entry stroke on baseline Added positive kerning to pairs with r.ful and e.ful and related groups. This issue affects a few models that contain print capitals in combination with full cursive lower cases. For example ES, IN and ZA

Confirmed it is working on fonts in Fixes branch at commit 3608fc Automated rebuild

vv-monsalve commented 1 month ago

@josescaglione I've finished the revision on the fixes branch. There are no font Fails reported, and the diffing images look good :)

The kerning issue reported above would remain the only pending issue before merging the fixes branch into the main and continuing with the font upgrade.

vv-monsalve commented 3 weeks ago

@josescaglione The above kerning case is solved in the fonts at commit 036752

Now, giving kerning a general overview, the following cases still need attention.

Touching or nearly touching between ‘of’ “of” of? of* of?

Screenshot 2024-11-05 at 16 03 58
Visible in the followin fonts - AU NSW - AU QLD - AU SA - AU TAS - DE Grund - DK Uloopet - FR Moderne - GB S - IS - NO - NZ - US Modern




Too distant ’A

Screenshot 2024-11-05 at 16 39 50
Visible in the followin fonts - DE SAS - ES - FR Moderne - FR Trad




Too distant ”A and d’œ

Screenshot 2024-11-05 at 16 20 46
Visible in the followin fonts - FR Trad - HU - ID - NG Modern - PL - PT - VN
vv-monsalve commented 3 weeks ago

@josescaglione We have decided to keep the current fonts as they are to proceed with producing the prioritized guide variants. We will leave this issue open so that the bove reported cases can be reconsidered for a different font version in the future.

Please merge the fixes branch into main.

cc @chrissimpkins