TypeTogether / Playwrite

Sensei primary repository.
SIL Open Font License 1.1
104 stars 4 forks source link

Readme + building instructions #16

Open vv-monsalve opened 1 year ago

vv-monsalve commented 1 year ago

Please update the README.md file with the following:

vv-monsalve commented 8 months ago

Lets keep this open until we migrate to Builder2

vv-monsalve commented 5 months ago

Hi @casasin

After having a 1:1 result between the builder2 and the lang-build fonts, today, we gave the green light to migrate to builder2. The following steps are needed to complete the migration:

Please report to us about any questions or issues you might have during the transition time.

cc @simoncozens, @chrissimpkins, @davelab6

simoncozens commented 5 months ago

Just to confirm, bba3221 Update sources is part of the builder2 branch.

casasin commented 5 months ago

Got it. Thanks and so cool @simoncozens ! Some questions:

Is this right or am I missing some or updating something not needed? (I'll wait for confirmation before pushing our latest updates)

Many thanks for your help.

simoncozens commented 5 months ago

Should I add "build.stamp", "fonts/", "sources/.ninja_log" and "sources/build.ninja" to .gitignore ? (as these are changed with every build locally).

You may want to check in the built fonts for convenience, but the others should go in .gitignore, yes.

When we have updates: Which are the files that are enough to be updated?

sources/fea-models and /sources/features/Playwrite-models.fea are no longer used. Everything is driven from the models-all.csv file and the main feature code. So just the glyphspackage file, the main feature file and models-all.csv.

~When models-all is changed, the configuration file needs to change as well. But I will add a commit automating that in the makefile.~ (I forgot that I already did this!)

vv-monsalve commented 5 months ago

Bringing here the comment from José in #52

There should be some rewriting of the Create or edit handwriting models section, also we need to see whether the doc mentioned in that section is still valid.

casasin commented 5 months ago

I'm working on it, I'll update it right today.

casasin commented 5 months ago

@vv-monsalve @josescaglione : README.md has been updated. Please have a look and close the issue if all is ok now.

vv-monsalve commented 4 months ago

I've created a PR that introduces a CHANGELOG.md file.

Following that, we should include a "Releasing" section in the Readme with instructions on the required steps to create a new one.

cc @simoncozens since we might review the current release process.