Closed vv-monsalve closed 4 months ago
@vv-monsalve this error is no longer triggered. Kindly close the issue
@josescaglione as we discussed during the meeting, after the visual comprobations I'll go back to the FB checks and report back or close the issues regarding them.
Confirmed
Hi @casasin the source file still has a positive slant axis value slnt = 18
, which means a backward slant. Since the slant axis is interpreted counter-clockwise, for a typical right-leaning font it is expected a negative slant value, so it should be slnt = -18
. This is important when we slice the VFs and compute the post.italicAngle.
Please change that value at the source level.
This value is still positive in the source file in lang-build
branch at commit 658f99f
.
@simoncozens Is this what is preventing builder2
from creating the Italic fonts?
The italic fonts are being built correctly, but I agree that the slant axis should be changed in the sources.
The specification of the slnt axis says that
Values can be interpreted as the angle, in counter-clockwise degrees
Glyphs is a bit funny here - it interprets italic angles in static fonts (e.g. post.italicAngle) as clockwise claiming this is "more intuitive", and then flips the sign on export. But it isn't what the spec says, and it means when people use the same values for their slnt
axes they produce fonts that are not compliant with the spec.
This was already done. Close? : )
Confirmed this is ok on the source file a commit cc1f569
. Closing it now :)
According to the spec:
There is a Fail reported related to this for the VF at commit
ea9393d
🔥 FAIL: Checking direction of slnt axis angles (com.google.fonts/check/slant_direction)