TypeTogether / Playwrite

Sensei primary repository.
SIL Open Font License 1.1
104 stars 4 forks source link

🔥 FAIL: Checking post.italicAngle value. #19

Closed vv-monsalve closed 12 months ago

vv-monsalve commented 1 year ago

The following Fail is reported for most of the families at commit 1b4d055

🔥 FAIL: Checking post.italicAngle value. (derived from com.google.fonts/check/italic_angle) (com.google.fonts/check/italic_angle)
> >The 'post' table italicAngle property should be a reasonable amount, likely not more than 30°. Note that in the OpenType specification, the value is negative for a rightward lean. > >https://docs.microsoft.com/en-us/typography/opentype/spec/post > * 🔥 **FAIL** The value of post.italicAngle is positive, which is likely a mistake and should become negative for right-leaning Italics. post.italicAngle: 18.0 angle calculated from outlines: -18.0) [code: positive] * 🔥 **FAIL** Font is not italic, so post.italicAngle should be equal to zero. [code: non-zero-upright]
vv-monsalve commented 1 year ago

Please find the complete reports at https://github.com/TypeTogether/Playpen/tree/QA-lang/qaPlaypen/FB-reports-1b4d055

List of reports including the fail - qaPlaypen/FB-reports-ea9393d/qaPlaypen-AUS-NSW-vf.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-AUS-NSW.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-AUS-QLD-vf.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-AUS-QLD.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-AUS-SA-vf.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-AUS-SA.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-AUS-TAS-vf.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-AUS-TAS.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-AUS-VIC-vf.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-AUS-VIC.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-BEL-VLG-vf.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-BEL-VLG.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-CAN-vf.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-CAN.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-COL-vf.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-COL.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-CUB-vf.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-CUB.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-CZE-vf.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-CZE.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-DEU-LA-vf.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-DEU-LA.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-DEU-SAS-vf.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-DEU-SAS.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-DEU-VA-vf.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-DEU-VA.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-DNK-looped-vf.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-DNK-looped.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-DNK-unlooped-vf.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-DNK-unlooped.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-HRV-vf.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-HRV.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-IRL-vf.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-IRL.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-ISL-vf.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-ISL.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-MEX-vf.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-MEX.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-NLD-vf.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-NLD.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-NOR-vf.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-NOR.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-NZL-vf.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-NZL.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-SVK-vf.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-SVK.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-USA-Tra-vf.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-USA-Trad.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-ZAF-vf.md - qaPlaypen/FB-reports-ea9393d/qaPlaypen-ZAF.md
casasin commented 1 year ago

This should be fixed with latest fonts

vv-monsalve commented 1 year ago

It's still present in the fonts at commit 23d4a217f

vv-monsalve commented 1 year ago

Still reported for fonts at commit 07c8561

josescaglione commented 1 year ago

@vv-monsalve if we change the italic angle to zero, then the caretSlopeRise and caretSlopeRun are triggered as errors. In short, one of those will trigger an error with current settings.Please let us know how to proceed

vv-monsalve commented 1 year ago

Sure, I'll dig into this. However, during today's meeting, you mentioned you already had considered or have a preference on how to proceed. Please expand your concerns/reasonings here.

josescaglione commented 1 year ago

My preference and advice is to let the caret fail. This is what we did in the static fonts so far.

Screen Shot 2023-10-05 at 06 02 54
vv-monsalve commented 12 months ago

We are talking about two different but related things.

PlaywriteCOL

VF

Screen Shot 2023-10-10 at 14 00 39 Screen Shot 2023-10-10 at 14 02 12

Static

Screen Shot 2023-10-10 at 15 11 03
casasin commented 12 months ago

Done with latest ARG and COL [wght] variables at cac910fdb

vv-monsalve commented 12 months ago

Confirmed for the VFs. Please make the same settings for the static fonts. Currently (at commit 890e814) the COL statics have

    <caretSlopeRise value="1000"/>
    <caretSlopeRun value="325"/>