search

TypeTogether / Playwrite

Sensei primary repository.
SIL Open Font License 1.1
93 stars 3 forks source link

🔥 FAIL: PPEM must be an integer on hinted fonts. #20

Closed vv-monsalve closed 9 months ago

vv-monsalve commented 10 months ago
🔥 FAIL: PPEM must be an integer on hinted fonts. (com.google.fonts/check/integer_ppem_if_hinted)
> >Hinted fonts must have head table flag bit 3 set. > >Per https://docs.microsoft.com/en-us/typography/opentype/spec/head, bit 3 of Head::flags decides whether PPEM should be rounded. This bit should always be set for hinted fonts. > >Note: Bit 3 = Force ppem to integer values for all internal scaler math; May use fractional ppem sizes if this bit is clear; > * 🔥 **FAIL** This is a hinted font, so it must have bit 3 set on the flags of the head table, so that PPEM values will be rounded into an integer value. This can be accomplished by using the 'gftools fix-hinting' command: ``` # create virtualenv python3 -m venv venv # activate virtualenv source venv/bin/activate # install gftools pip install git+https://www.github.com/googlefonts/tools ``` [code: bad-flags]

Please find the complete reports at https://github.com/TypeTogether/Playpen/tree/QA-lang/qaPlaypen/FB-reports-1b4d055

List of reports including the fail - qaPlaypen/FB-reports-1b4d055/qaPlaypen-ARG-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-AUS-NSW-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-AUS-QLD-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-AUS-SA-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-AUS-SA.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-AUS-TAS-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-AUS-TAS.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-AUS-VIC-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-BEL-VLG-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-BEL-VLG.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-BEL-WAL-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-BRA-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-BRA.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-CAN-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-CAN.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-CHI-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-CHI.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-COL-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-COL.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-CUB-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-CZE-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-CZE.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-DEU-Gru-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-DEU-Gru.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-DEU-LA-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-DEU-LA.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-DEU-SAS-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-DEU-SAS.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-DEU-VA-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-DEU-VA.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-DNK-looped-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-DNK-looped.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-DNK-unlooped-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-DNK-unlooped.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-ESP-OrnateUC-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-ESP-Ornated.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-ESP-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-ESP.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-FRA-Mod-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-FRA-Mod.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-FRA-Tra-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-FRA-Trad.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-HRV-Lefthand-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-HRV-Lefthand.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-HRV-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-HRV.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-IDN-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-IRL-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-IRL.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-ISL-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-ITA-Mod-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-ITA-Mod.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-ITA-Tra-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-ITA-Trad.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-MEX-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-MEX.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-NLD-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-NLD.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-NOR-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-NZL-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-NZL.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-PER-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-PER.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-POL-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-POL.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-POR-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-POR.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-SVK-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-SVK.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-USA-Mod-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-USA-Tra-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-USA-Trad.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-VNM-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-ZAF-vf.md - qaPlaypen/FB-reports-1b4d055/qaPlaypen-ZAF.md
vv-monsalve commented 9 months ago

Leaving the VFs unhinted (running after gftools fix-nonhinting) this will no longer be an issue.