TypeTogether / Playwrite

Sensei primary repository.
SIL Open Font License 1.1
85 stars 3 forks source link

Diacritic marks issues #26

Closed vv-monsalve closed 2 months ago

vv-monsalve commented 7 months ago

I'll report here all the marks issues spotted. The following cases were found in fonts at commit 5d75173

Ydotbelow

In Ydotbelow the dot is typically placed to the right of the letter.

Australia NSW

Screen Shot 2023-11-14 at 23 12 08
vv-monsalve commented 7 months ago

zcaron and zacute

josescaglione commented 7 months ago

I'll report here all the marks issues spotted. The following cases were found in fonts at commit 5d75173

Ydotbelow

In Ydotbelow the dot is typically placed to the right of the letter.

Australia NSW

Screen Shot 2023-11-14 at 23 12 08

Hi Viviana, in this case we placed the dot below the baseline as I thought it would be odd to do it above it. for a capital letter. It is a very odd shape for a cap. Should I try lifting it anyway?

vv-monsalve commented 7 months ago

What Nhung, our Vietnamese consultant, has told us is they always use it to the right side. They find it weird to see it below.

vv-monsalve commented 5 months ago

The fonts in the lang-build branch at commit 658f99f still need to place the dot on the right side of the letter.

England Semijoin

Screen Shot 2024-02-06 at 16 26 50
josescaglione commented 5 months ago

Hi @vv-monsalve we consulted with Donny Truong and sent him the samples we were using

Screenshot 2024-02-07 at 08 50 37 Screenshot 2024-02-07 at 08 52 07

and also sent him the sample in the unjoined version

Screenshot 2024-02-07 at 08 57 53

His reply: For the looped y’s, the underdot you have might be OK, but the unlooped is odd. My recommendation would be to customize the descenders with the dots under them. Make the dotted-y its own glyph. I created a rough illustration to demonstrate what I mean. Let me know if you have further questions.

Screenshot 2024-02-07 at 14 28 13

And I add: And we could try the same approach with the looped version but that is not what the current viet model looks like:

Screenshot 2024-02-07 at 14 28 56
josescaglione commented 5 months ago

Another consultant got back to me. His notes below:


About this ydotbelow, I'm looking at many VN primary handwriting exercises/textbooks to find some references. But the thing is this character is not so frequent in our language. I've been looking through some but have only found one example through a picture of a teacher (https://www.facebook.com/lathi.thuthuy.9/) You can see here a tiny dot below the bowl in the word "huỵch".

Screenshot 2024-02-08 at 11 38 46

I tried writing them to see how my hand goes with the muscle memory and it's more natural to have it below the bowl.

Screenshot 2024-02-08 at 11 40 09
josescaglione commented 5 months ago

Now, the problem is that all accents are positioned on the fly to reduce font size and feature file processing load. So, if we need to have a precomposed shape for any of the versions of ydotbelow then we need to have one for all. Adding this implies working on 4 versions: precursive, .mod, .jmc, .cnt on all 16 masters, so 208 designs (many would be composites)

I wonder if we should place on the right side for precursive and .mod only, and leave on the right for the other two.

Screenshot 2024-02-08 at 11 47 42
vv-monsalve commented 5 months ago

all accents are positioned on the fly to reduce font size and feature file processing load. So, if we need to have a precomposed shape for any of the versions of ydotbelow then we need to have one for all.

I wonder if we should place on the right side for precursive and .mod only, and leave on the right for the other two.

Screen Shot 2024-02-08 at 10 09 59

I will advocate for any solution that favors on-the-fly composition and doesn't imply a change in shape. Nhung has told us it could always be at the right since there are no combinations of letters that could create a clash (on standard fonts). Although I recognize a joined model could bring different situations, thus it could be this one you propose for precursive and mod.

davelab6 commented 5 months ago

I concur with @vv-monsalve

josescaglione commented 5 months ago

ok, its decided then, thank you both for reviewing!

vv-monsalve commented 4 months ago

This was fixed for most of the fonts in lang-build branch at commit cc1f569.

However, you would like to review the following cases to refine the dot position.

vv-monsalve commented 2 months ago

Ok in latest fonts at c08ea9f1da47a53d097fd551646b8d1c3fb0c8ee