TypeTogether / Playwrite

Sensei primary repository.
SIL Open Font License 1.1
104 stars 4 forks source link

`lslash` position issues #27

Closed vv-monsalve closed 8 months ago

vv-monsalve commented 10 months ago

lslash

In some models, the slash looks like different positions for the stroke, in some cases showing some congestion with the l loop.

Screen Shot 2023-11-15 at 0 10 52

(Edit: moving here this issue previously reported in diacritics marks issue)

vv-monsalve commented 10 months ago

The stroke in lslash needs to be more distinguishable, and avoid collisions.

Colombia

Screen Shot 2023-11-29 at 22 56 56

England SemiJoined

Screen Shot 2023-11-29 at 23 14 28
josescaglione commented 10 months ago

noted, will fix

josescaglione commented 10 months ago

@vv-monsalve , we tried a new approach to the design of /lslash, crossing the slash only on the left side of the loop. As I mentioned, none of these loopy models are meant to be used with bar/slash diacritics, but I feel this may be more recognizable now. If you and @davelab6 like it I can repeat in /hbar.

vv-monsalve commented 10 months ago

@josescaglione, inspecting the fonts at commit 3a4e55 this looks more recognizable indeed now. And similar strategy can be applied to all the bar or stroked letters.

The bar could be slightly below the connection stroke in models like the Englan SemiJoined at the Regular weight so it doesn't collide.

As I mentioned, none of these loopy models are meant to be used with bar/slash diacritics

Please keep in mind that these are our standard tests for all of our fonts, considering they always end up being used outside of the specific environments they were originally designed for.

Colombia

Screen Shot 2023-12-05 at 9 03 39

England SemiJoined

Screen Shot 2023-12-05 at 9 16 39

France Traditional

Screen Shot 2023-12-05 at 9 17 09
josescaglione commented 10 months ago

hi @vv-monsalve I shifted the bar in h to the left as agreed. Regarding the 7lslash I reviewed the original Falski's design and decided to shift it up to avoid collisions. All of this will be visible in the next commit. Looking very nice I thin/.

I noticed that the bar in /hbar for the slanted designs look a bit shifted in your sample. Could you please send me the string you are using for that test? Want to double check it here

vv-monsalve commented 10 months ago

Hi @josescaglione this is the string used

ďá ďu gj ľk włw yły ółr fħ ílïlîl

josescaglione commented 10 months ago

Thank you, lets check again in the next commit but this should be ok now.

vv-monsalve commented 8 months ago

The fonts in the lang-build branch at commit 658f99f are looking much better now.

Colombia

Screen Shot 2024-02-06 at 16 07 39

England SemiJoined Italic

Screen Shot 2024-02-06 at 16 10 13

France Traditional

Screen Shot 2024-02-06 at 16 08 29