TypeTogether / Playwrite

Sensei primary repository.
SIL Open Font License 1.1
85 stars 3 forks source link

Quotation marks position #28

Closed vv-monsalve closed 4 months ago

vv-monsalve commented 7 months ago

The quotation marks position is working with Uppercase and ascender height. However, when used with lowercase letters they look shifted up. Should we find a compromise in the position by making it a bit lower?

E.g. France Traditional

Screen Shot 2023-11-29 at 23 07 11
josescaglione commented 7 months ago

Hi @vv-monsalve , how many UPM would you shift them? Please be aware that we cannot have localised punctuation so any changes in the tall masters will have an impact in a lot of the models. Am I right to asume that this also impact on quotesingle quotedbl quoteleft quoteright? What about asterisk ?

The French fonts have no curly double quotes but just straight ones. See the capture here.

Screen Shot 2023-11-30 at 07 24 06
josescaglione commented 7 months ago

sorry, I forgot to add my opinion for what is worth... I think the vertical position and size of these signs in Playwrite are correct. Shifting the quotes down will make it look odd when used with caps or ascenders.

vv-monsalve commented 7 months ago
Screen Shot 2023-11-30 at 19 20 44

Based on our review today, the following is a list of comments and suggestions for your consideration.

Single quotation mark or apostrophe used in common contractions for languages like English or French

Alternatives of solution:

josescaglione commented 7 months ago

Thanks for your comments @vv-monsalve , we will make them longer and shift them down.

josescaglione commented 7 months ago
Screen Shot 2023-12-01 at 07 57 48

@vv-monsalve this is 60UPM longer, minus 200 vertical shift. Please let me know if it is ok and we can repeat in other masters

vv-monsalve commented 7 months ago

After a pair review, this looks better now. There is the added recommendation on kerning to t' and ,' pairs

josescaglione commented 7 months ago

Cool, I passed on the kerning comment to Vik. She generally thinks we should maintain it fairly open and prefers not to touch these pairs. But she will nevertheless review

vv-monsalve commented 7 months ago

I was adding more info but didn't make to publish them before your last comment:

Some added comments suggest to:

josescaglione commented 7 months ago

I will make some tests and we can go over them in the next meeting. I must say I did try to make them longer suring last revision and starts looking really bad. Will check again though.

josescaglione commented 7 months ago

FYI, I changed the thin masters to make comma and all quotes a bit longer and lighter as requested. Also changed the Regular masters for the comma and baseline quotes. Reaching the cap height with quotes is not working as we have a difference os 200 UPM. This should be visible in the next commit.

davelab6 commented 7 months ago

Localizing the position for the models with long ascenders.

I think this, done as case feature, would be ideal - but not for this v1 release, and likely as part of a future round of careful Primarium research that specifically investigates quote marks and other punctuation

josescaglione commented 7 months ago

Thanks @davelab6 . Agreed

vv-monsalve commented 7 months ago

I think this, done as case feature, would be ideal - but not for this v1 release

Excellent!

This should be visible in the next commit.

@josescaglione please ping me when you push the latest files into the lang-build branch, so we can find the v1 release shape definition.

vv-monsalve commented 5 months ago

This is the position of the current quotes in the France Traditional (one of the highest ascenders) in the lang-build branch at commit 658f99f

They look good for the v1 release. @davelab6

Screen Shot 2024-02-06 at 16 06 14 Screen Shot 2024-02-06 at 16 00 37
casasin commented 4 months ago

@vv-monsalve : Is this issue ready to be closed then?

vv-monsalve commented 4 months ago

Fonts in lang-build branch at commit cc1f569 look good for v1 release. There are some kerning cases, but I'll report them in the related issue.