TypeTogether / Playwrite

Sensei primary repository.
SIL Open Font License 1.1
85 stars 3 forks source link

Romanian and Moldovan localization #30

Closed vv-monsalve closed 4 months ago

vv-monsalve commented 7 months ago

@josescaglione, we are implementing a new check now for shaping languages that will ensure these requirements:

casasin commented 7 months ago

Fixed in new fonts.

vv-monsalve commented 5 months ago

The fonts in the lang-build branch at commit 658f99f still include the T, t cedilla.

Edit: Please remove them from the fonts/source file

Screen Shot 2024-02-06 at 15 57 02
vv-monsalve commented 5 months ago
🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
> >This check uses a heuristic to determine which GF glyphsets a font supports. Then it checks the font for correct shaping behaviour for all languages in those glyphsets. > * 🔥 **FAIL** GF_Latin_Core glyphset: | Language | FAIL messages | | :--- | :--- | | nl_Latn (Dutch) | Shaper didn't attach acutecomb to j.jmc.fin | | ro_Latn (Romanian) | in Romanian, S-cedilla should become S-comma-accent; both buffers returned S.dec=0+941|uni0327.case=0@-583,0+0 | [code: failed-language-shaping]

This Fail is reported for the following families:

josescaglione commented 4 months ago

@vv-monsalve just to let you know that we tested this on our latest fonts and it seems solved. Could you please test and confirm?

vv-monsalve commented 4 months ago

This was fixed for fonts in lang-build branch at commit cc1f569