search

TypeTogether / Playwrite

Sensei primary repository.
SIL Open Font License 1.1
85 stars 3 forks source link

GB-SemiJoined-Italic `hhea.caretSlopeRun` value #31

Closed vv-monsalve closed 7 months ago

vv-monsalve commented 7 months ago
🔥 FAIL: Check hhea.caretSlopeRise and hhea.caretSlopeRun (com.google.fonts/check/caret_slope)
> >Checks whether hhea.caretSlopeRise and hhea.caretSlopeRun match with post.italicAngle. > >For Upright fonts, you can set hhea.caretSlopeRise to 1 and hhea.caretSlopeRun to 0. > >For Italic fonts, you can set hhea.caretSlopeRise to head.unitsPerEm and calculate hhea.caretSlopeRun like this: round(math.tan( math.radians(-1 * font["post"].italicAngle)) * font["head"].unitsPerEm) > >This check allows for a 0.1° rounding difference between the Italic angle as calculated by the caret slope and post.italicAngle > * 🔥 **FAIL** hhea.caretSlopeRise and hhea.caretSlopeRun do not match with post.italicAngle. Got: caretSlopeRise 1000 and caretSlopeRun 231 Expected: caretSlopeRise 1000 and caretSlopeRun 123 [code: caretslope-mismatch]
casasin commented 7 months ago

This is fixed in latest fonts. Close the issue after checking this is ok again.

vv-monsalve commented 7 months ago

Confirming this is no longer reported for the font at commit f68964