search

TypeTogether / Playwrite

Sensei primary repository.
SIL Open Font License 1.1
85 stars 3 forks source link

⚠️ WARN Ensure Stylistic Sets have description. #41

Closed vv-monsalve closed 2 months ago

vv-monsalve commented 2 months ago

@simoncozens, the Stylistic Sets have lost their names.

The names seem included in the name table but are not recognized in the fonts. Actually, something weird is happening in the table in general: the other axes appear listed (slant, speed, Y extension), and the instances are listed more than once (pics below).

⚠️ WARN Ensure Stylistic Sets have description.
> > Stylistic sets should provide description text. Programs such as InDesign, > TextEdit and Inkscape use that info to display to the users so that they know > what a given stylistic set offers. > > Original proposal: https://github.com/fonttools/fontbakery/issues/3155 * ⚠️ **WARN**

The stylistic set ss01 lacks a description string on the 'name' table.

[code: missing-description] * ⚠️ **WARN**

The stylistic set ss02 lacks a description string on the 'name' table.

[code: missing-description] * ⚠️ **WARN**

The stylistic set ss03 lacks a description string on the 'name' table.

[code: missing-description] * ⚠️ **WARN**

The stylistic set ss04 lacks a description string on the 'name' table.

[code: missing-description] * ⚠️ **WARN**

The stylistic set ss05 lacks a description string on the 'name' table.

[code: missing-description] * ⚠️ **WARN**

The stylistic set ss06 lacks a description string on the 'name' table.

[code: missing-description] * ⚠️ **WARN**

The stylistic set ss07 lacks a description string on the 'name' table.

[code: missing-description] * ⚠️ **WARN**

The stylistic set ss19 lacks a description string on the 'name' table.

[code: missing-description] * ⚠️ **WARN**

The stylistic set ss20 lacks a description string on the 'name' table.

[code: missing-description]

name table on latest build

Screen Shot 2024-04-19 at 19 22 05

name table from previous (TT) build

Screen Shot 2024-04-19 at 19 30 00

Comparison between builds

Screen Shot 2024-04-19 at 19 09 35
simoncozens commented 2 months ago

These appear to be dropped by the remapLayout step (when we move the locl/ccmp features into calt to stop the InDesign problem). So gftools-remap-layout is not maintaining these names; I'll fix the issue in gftools.