TypeTogether / Playwrite

Sensei primary repository.
SIL Open Font License 1.1
93 stars 3 forks source link

⚠️ Interpolation issues #7

Closed vv-monsalve closed 5 months ago

vv-monsalve commented 11 months ago

While this warning can point out some characteristics that may be by design, it has proven valuable in detecting interpolation issues. Please inspect all of the listed glyphs (at the bottom) and solve the wrong cases.

E.g. - Glyph name: uni1EE1 Contours detected: 6 Expected: 3 makes it possible to detect the following glyph in font: <img width="134" alt="Screen Shot 2023-08-28 at 18 52 57" src="https://github.com/TypeTogether/Playpen/assets/48698976/f74668d1-96b2-454c-a297-c798d17b84c8">

Which allows catching an interpolation issue caused by a discrepancy between the first nodes in tildeshortcomb in the source file.

Screen Shot 2023-08-28 at 18 54 15
WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
> >Visually QAing thousands of glyphs by hand is tiring. Most glyphs can only be constructured in a handful of ways. This means a glyph's contour count will only differ slightly amongst different fonts, e.g a 'g' could either be 2 or 3 contours, depending on whether its double story or single story. > >However, a quotedbl should have 2 contours, unless the font belongs to a display family. > >This check currently does not cover variable fonts because there's plenty of alternative ways of constructing glyphs with multiple outlines for each feature in a VarFont. The expected contour count data for this check is currently optimized for the typical construction of glyphs in static fonts. > * ⚠ **WARN** This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct. The following glyphs do not have the recommended number of contours: - Glyph name: Eth Contours detected: 3 Expected: 2 - Glyph name: aogonek Contours detected: 3 Expected: 2 - Glyph name: Dcroat Contours detected: 3 Expected: 2 - Glyph name: dcroat Contours detected: 3 Expected: 2 - Glyph name: eogonek Contours detected: 3 Expected: 2 - Glyph name: hbar Contours detected: 2 Expected: 1 - Glyph name: itilde Contours detected: 4 Expected: 2 - Glyph name: Lslash Contours detected: 2 Expected: 1 - Glyph name: lslash Contours detected: 2 Expected: 1 - Glyph name: Tbar Contours detected: 2 Expected: 1 - Glyph name: tbar Contours detected: 2 Expected: 1 - Glyph name: Uogonek Contours detected: 2 Expected: 1 - Glyph name: uogonek Contours detected: 2 Expected: 1 - Glyph name: ohorn Contours detected: 3 Expected: 2 - Glyph name: Uhorn Contours detected: 2 Expected: 1 - Glyph name: uhorn Contours detected: 2 Expected: 1 - Glyph name: uni1EDB Contours detected: 4 Expected: 3 - Glyph name: uni1EDD Contours detected: 4 Expected: 3 - Glyph name: uni1EDF Contours detected: 4 Expected: 3 - Glyph name: uni1EE1 Contours detected: 6 Expected: 3 - Glyph name: uni1EE3 Contours detected: 4 Expected: 3 - Glyph name: uni1EE8 Contours detected: 3 Expected: 2 - Glyph name: uni1EE9 Contours detected: 3 Expected: 2 - Glyph name: uni1EEA Contours detected: 3 Expected: 2 - Glyph name: uni1EEB Contours detected: 3 Expected: 2 - Glyph name: uni1EEC Contours detected: 3 Expected: 2 - Glyph name: uni1EED Contours detected: 3 Expected: 2 - Glyph name: uni1EEE Contours detected: 3 Expected: 2 - Glyph name: uni1EEF Contours detected: 5 Expected: 2 - Glyph name: uni1EF0 Contours detected: 3 Expected: 2 - Glyph name: uni1EF1 Contours detected: 3 Expected: 2 - Glyph name: Dcroat Contours detected: 3 Expected: 2 - Glyph name: Eth Contours detected: 3 Expected: 2 - Glyph name: Lslash Contours detected: 2 Expected: 1 - Glyph name: Tbar Contours detected: 2 Expected: 1 - Glyph name: Uhorn Contours detected: 2 Expected: 1 - Glyph name: Uogonek Contours detected: 2 Expected: 1 - Glyph name: aogonek Contours detected: 3 Expected: 2 - Glyph name: dcroat Contours detected: 3 Expected: 2 - Glyph name: eogonek Contours detected: 3 Expected: 2 - Glyph name: hbar Contours detected: 2 Expected: 1 - Glyph name: itilde Contours detected: 4 Expected: 2 - Glyph name: lslash Contours detected: 2 Expected: 1 - Glyph name: ohorn Contours detected: 3 Expected: 2 - Glyph name: tbar Contours detected: 2 Expected: 1 - Glyph name: uhorn Contours detected: 2 Expected: 1 - Glyph name: uni1EDB Contours detected: 4 Expected: 3 - Glyph name: uni1EDD Contours detected: 4 Expected: 3 - Glyph name: uni1EDF Contours detected: 4 Expected: 3 - Glyph name: uni1EE1 Contours detected: 6 Expected: 3 - Glyph name: uni1EE3 Contours detected: 4 Expected: 3 - Glyph name: uni1EE8 Contours detected: 3 Expected: 2 - Glyph name: uni1EE9 Contours detected: 3 Expected: 2 - Glyph name: uni1EEA Contours detected: 3 Expected: 2 - Glyph name: uni1EEB Contours detected: 3 Expected: 2 - Glyph name: uni1EEC Contours detected: 3 Expected: 2 - Glyph name: uni1EED Contours detected: 3 Expected: 2 - Glyph name: uni1EEE Contours detected: 3 Expected: 2 - Glyph name: uni1EEF Contours detected: 5 Expected: 2 - Glyph name: uni1EF0 Contours detected: 3 Expected: 2 - Glyph name: uni1EF1 Contours detected: 3 Expected: 2 - Glyph name: uogonek Contours detected: 2 Expected: 1 [code: contour-count]
vv-monsalve commented 11 months ago

Another interpolation issue detected.

Screen Shot 2023-08-28 at 19 48 32
josescaglione commented 10 months ago

The issue has been solved but will be visible next time we generate fonts.

josescaglione commented 9 months ago

fixed

vv-monsalve commented 7 months ago

Hi @josescaglione. Please find here a PDF produced by Simon with all the interpolation issues detected at the source level.

Playwrite.pdf

vv-monsalve commented 5 months ago

The fonts in the lang-build branch at commit 658f99f look good so far. I'm closing this here and will reopen if something new arises.