TypeTogether / Playwrite

Sensei primary repository.
SIL Open Font License 1.1
93 stars 3 forks source link

⚠ Unreachable glyphs #9

Closed vv-monsalve closed 7 months ago

vv-monsalve commented 11 months ago

Please ensure all the glyphs in the fonts are accessible either by codepoint or substitution rules.

E.g.

WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
> >Glyphs are either accessible directly through Unicode codepoints or through substitution rules. > >In Color Fonts, glyphs are also referenced by the COLR table. > >Any glyphs not accessible by either of these means are redundant and serve only to increase the font's file size. > * ⚠ **WARN** The following glyphs could not be reached by codepoint or substitution rules: - A.cur_locl - A.dec_locl - AE.cur - AE.cur.locl - F.cur_locl - G.cur_locl - G_locl - IJ.cur - IJacute - I_locl - M_locl - OE.cur - OE.cur.locl - Q.cur_locl - Q.cur_locl.ini - Q.dec_pt - Q_locl - Q_locl.ini - T.cur_locl - X.dec_locl - Z.dec_locl - _circle - b.jmc_dk - cnct.ful_t.lop_de_e - cnct.mlp_b_s.mod - cnct.mod_e_z.ful - f.alt1.mrr - f.ful_pe - f.ful_pl - four.alt1 - i.loclTRK - ijacute - k.lop_pe - l.alt1.lop - nine.alt1 - one.alt1 - p.mrr_ca - seven.alt1 - t.lop_de - uni030C.alt_locl - uni0312.case - x.cnt_de - y_de [code: unreachable-glyphs]
josescaglione commented 11 months ago

Please lets discuss, as I pointed out in our meeting this may not be as simple.

vv-monsalve commented 11 months ago

Yes, I considered that. What is important is to make sure that all the necessary glyphs required by a model are available on each font. I uploaded the reports for all fonts in a QA-lang branch in qaPlaypen/FB-reports-bf1024ce directory. You can find the complete list of symbols for each font family there.

josescaglione commented 9 months ago

We already checked this, just missing the ij IJ ijacute IJacute for NDL

vv-monsalve commented 8 months ago

IJacute and ijacute are still reported as unreachable in the NL model at commit 7dd15b

vv-monsalve commented 7 months ago

@josescaglione we no longer require the ij or IJ ligatures or the locl feature by default in fonts. But we require idotless and jdotless with respective anchors so the composite can be built on the fly by demand by substitution rules.

This is related to the soft dotted glyphs requirement and the long reasoning around these marks elaborated here, which follows what is stated here.

Colombian model

Screen Shot 2023-12-02 at 14 21 30
josescaglione commented 7 months ago

Hello @vv-monsalve , could you please paste the text string here so we can verify the fix?

vv-monsalve commented 7 months ago

It is

dé, jé van hét, búíten, ééuwig, voorkómen, vóórkomen en blíj́ft

You can find it in the second link in the last comment, and also test it by typing the combining mark (acute) + the letter (j in this case). This should work to produce the "j́".

vv-monsalve commented 7 months ago

@josescaglione I can confirm this is working well now for our three VF benchmark models in the lang-build branch at commit 3a4e55a

Colombia

Screen Shot 2023-12-04 at 16 29 27

England SemiJoined

Screen Shot 2023-12-04 at 16 29 15

France Traditional

Screen Shot 2023-12-04 at 16 29 22