UBC-MDS / DSCI532_GROUP104_Movies

MIT License
1 stars 4 forks source link

General feedback for Milestone 1 #31

Open ellentkoch opened 4 years ago

ellentkoch commented 4 years ago

Mechanics: Ensure all links in your GitHub.ubc.ca README go to specific commit versions of the files. All of the necessary files are present in your Github.com repo.

Proposal: The purpose and the data description of the proposal are very clear, good work! The usage scenario uses specific examples of how the app can be used which is great. I’m a bit confused on how the “top 50 most productive directors in the past 50 years” is determined using the app, is this the default that shows when you select the “Drama” genre or does the user need to select filters for this? There are some subtle grammatical errors. “Top 50 productive directors” should be “Top 50 most productive directors”, etc.

Visualization: The visualization is very clear and visually appealing and the description is good. The text is a good size so it’s easy to read. Is the list of movies going to be a selection that the user chooses, or are all the movies going to be plotted at the same time? (it sounds like that may be a lot)

Team Contract/Code of Conduct: These look great. The team contract is specific and has instructions on what to do in different situations. Good work!

@flizhou @zouwenjiao @sweber15