Fixed DBC Error on Main - Githubissues

UBC-Solar / sunlink

UBC Solar's radio and cellular-based telemetry system

MIT License

3 stars 1 forks source link

Fixed DBC Error on Main #84

Closed AarjavJain101 closed 4 months ago

AarjavJain101 commented 4 months ago

Error Received: cantools.database.errors.Error: The signal <SOME_SIGNAL> length 0 is not greater than 0 in message MCBDiagnostics.

Problem:

This signal had a length of 0 bits which does not make sense.

Fix:

For all signals with this problem I changed the length accordingly based on the BOM. Now sunlink is working. Here is a 0x404 message for example. Note that this is randomizer mode and timestamps are current time in randomizer using the time.time() funciton.