search

UCLA-VAST / tapa

TAPA is a dataflow HLS framework that features fast compilation, expressive programming model and generates high-frequency FPGA accelerators.
https://tapa.rtfd.io
MIT License
144 stars 27 forks source link

Issue with tapac "--other-hls-configs" in Latest Release #156

Open logosAllen opened 3 months ago

logosAllen commented 3 months ago

Dear Author,

I recently downloaded and built the latest release from source. However, I've encountered an issue with the "--other-hls-configs" option. Specifically, when I set the following configurations:

--other-hls-configs "config_compile -pipeline_style frp" \ --other-hls-configs "config_rtl -reset all"

it appears that these settings are not being reflected in the generated HDL. Could you please look into this? Any guidance or fixes would be greatly appreciated.

Thank you for your assistance.

Blaok commented 2 months ago

This is another feature accidentally broken by https://github.com/UCLA-VAST/tapa/commit/898fbf52d8b511407e212e031c5f8b2affe3be7c. Again, I'll add it back when I have time :)

logosAllen commented 2 months ago

Thank you for your enthusiastic contribution.

Blaok commented 2 months ago

Fixed by 7ae5c46527f8b30ec3f04e0446dfd3b25b9d8343.