search

UI-Research / mobility-from-poverty

https://ui-research.github.io/mobility-from-poverty/
4 stars 1 forks source link

218 #287

Closed kmartinchek closed 3 months ago

kmartinchek commented 4 months ago

Issue 218 for review

kmartinchek commented 4 months ago

I updated the code and pushed to branch 218.

kmartinchek commented 4 months ago

Changed the call to locals from globals-- code just needs final approval.

kmartinchek commented 4 months ago

Hmm I am quite confused because when I look at branch 218 on GitHub and my local, the quotes ` and ' are there for all locals. I looked and tried to re-save and commit but it tells me the working tree is clean.

I think you are looking at the temp file (do.stswp) instead of the final .do file and that could be the error.

awunderground commented 4 months ago

@kmartinchek Can we delete the temp file? Is it needed in the GitHub repo?

kmartinchek commented 4 months ago

Removed temp files.

kmartinchek commented 3 months ago

To respond: -I moved up the ssc install to top of do file -When I run count if missing(subgroup) and count if missing(subgroup_type), there are no missing values and tab also shows no missingness -The final csv had 25,144 observations, or 8 observations (1 for overall and 7 industries) for each of the 3.143 counties. I also added code to check that this is the case for all counties.

Can you give a little more detail on the files you were reviewing? From my end, it seems that these errors are not present and it seems like the .csv on GitHub has the right output as well.