search

UM-ARM-Lab / smmap

Simultaneous Modeling Manipulation And Planning
1 stars 3 forks source link

Quinlan band implementation, and other bug fixes #17

Closed dmcconachie closed 6 years ago

dmcconachie commented 6 years ago

There are parts of this code that still need to be cleaned up (in particular some of the visualization, and the usage of some of the SDF functions), but we need some of the bug fixes in here to be merged into master. These bug fixes cannot be split out from the other changes without significant work, so I'd like to go ahead and merge anyway, and create an issue for me to go in and fix those things.

@ruanmiao Do your experiments still run with this code? This requires the SmmapLiveRobot branch of arc_utilities and the FixingEstimateDistanceForSMMAP of sdf_tools to compile.

ruanmiao commented 6 years ago

Should I pull a specific branch of deformable_manipulation_interface? I tried both master and ISRR_2017_Quinlan_Band_Trials, it kept reporting errors...

ruanmiao commented 6 years ago

By reading directly from planner.cpp though, I think it is doing the right thing.

dmcconachie commented 6 years ago

I apparently forgot to push some changes to deformable_manipulation_interface. Pull and checkout the MergingQuinlanIntoMaster branch of that repo.

dmcconachie commented 6 years ago

I'm going to go ahead and merge this, let me know if you have any problems and we can revisit this.

ruanmiao commented 6 years ago

Hi Dale,

I have: Smmap master deform_control master deformable_manipulation_interface master arc_utility SmmapLiveRobot sdf_tool FixingEstimatieDistanceForSmmap

While it still reports that: "[image: Inline image 1]"

Does it happen to you as well?

On Thu, Nov 16, 2017 at 1:51 PM, Dale McConachie notifications@github.com wrote:

Merged #17 https://github.com/UM-ARM-Lab/smmap/pull/17.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/UM-ARM-Lab/smmap/pull/17#event-1345756348, or mute the thread https://github.com/notifications/unsubscribe-auth/AM7lANvsXANerQgmmIqaR6EhgfnhFzECks5s3IQzgaJpZM4Qf11t .

-- Mengyao Ruan Mechanical Engineering, B.S.E. 2016 University of Michigan Electrical and Computer Engineering, B.S.E. 2016 Shanghai Jiao Tong University

dmcconachie commented 6 years ago

I've never seen that before. Try arc_utilities at master (make sure you pull everything, I just merged a bunch of changes in.)

dmcconachie commented 6 years ago

Oh, I see, that's github's attempt to inline an image, not an actual error message. So it's possible my response is still relevant.

dmcconachie commented 6 years ago

You will also need the smmap_utilities repo

ruanmiao commented 6 years ago

(Yeah, I had smmap_utilities repo as well)

On Thu, Nov 16, 2017 at 3:54 PM, Dale McConachie notifications@github.com wrote:

You will also need the smmap_utilities repo

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/UM-ARM-Lab/smmap/pull/17#issuecomment-345059309, or mute the thread https://github.com/notifications/unsubscribe-auth/AM7lAGXUs8mizV2Ntw1p5WCTvnmdiUV4ks5s3KETgaJpZM4Qf11t .

-- Mengyao Ruan Mechanical Engineering, B.S.E. 2016 University of Michigan Electrical and Computer Engineering, B.S.E. 2016 Shanghai Jiao Tong University

ruanmiao commented 6 years ago

Now I'm on master of arc_utilities while there are still some errors....

[image: Inline image 1]

On Thu, Nov 16, 2017 at 3:58 PM, Mengyao Ruan ruanmiao@umich.edu wrote:

(Yeah, I had smmap_utilities repo as well)

On Thu, Nov 16, 2017 at 3:54 PM, Dale McConachie <notifications@github.com

wrote:

You will also need the smmap_utilities repo

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/UM-ARM-Lab/smmap/pull/17#issuecomment-345059309, or mute the thread https://github.com/notifications/unsubscribe-auth/AM7lAGXUs8mizV2Ntw1p5WCTvnmdiUV4ks5s3KETgaJpZM4Qf11t .

-- Mengyao Ruan Mechanical Engineering, B.S.E. 2016 University of Michigan Electrical and Computer Engineering, B.S.E. 2016 Shanghai Jiao Tong University

-- Mengyao Ruan Mechanical Engineering, B.S.E. 2016 University of Michigan Electrical and Computer Engineering, B.S.E. 2016 Shanghai Jiao Tong University

dmcconachie commented 6 years ago

I can't see that image. Try adding the image via a post directly on github instead of via an email reply.