UMB-CS682-Team-02 / tracker

0 stars 1 forks source link

Provide legend/axis labels for non-pie charts that have more than one group property #50

Closed rouilj closed 6 months ago

rouilj commented 6 months ago

The chart titles include information about the group properties. However the legend and X axis have the property labels (e,g bugs, feature or critical, urgent etc.), but no facet/dimension label.

Use chart.x_title from pygal to add an X title.

rouilj commented 6 months ago

Is this on main? I don't see it? Please don't close tickets until they are on main.

rouilj commented 6 months ago

I don't see any reference to x_title in chart.py, so I don;t think this was completed. Possibly confused with the ticket for setting chart.title correctly.

rouilj commented 6 months ago

Read the pygal documentation for the x_title parameter to add a title to the x-axis for all of the bar charts.

If you had a chart of issues grouped by priority and status, the X axis (of my ascii bar chart below) would have labels like:

             *           *
             *           *     *
             *     *     *     *
         critical bug feature wish

this issue calls for adding a title for the x axis so that it looks like

             *           *
             *           *     *
             *     *     *     *
         critical bug feature wish

                  priority
ashrith-UMB commented 6 months ago

Title for X axis has been added using x_title parameter from pygal. Commit : https://github.com/UMB-CS682-Team-02/tracker/commit/bda2964eaf512a55fb4da43a06cf04b9362448f0

rouilj commented 6 months ago

LGTM