8 as user i would like to see standard unhcr color and font in order to recognise the brand

UNHCR-Guatemala / A2SIT

Admin2 Severity Index Tool

https://unhcr-guatemala.github.io/A2SIT/

Other

2 stars 1 forks source link

8 as user i would like to see standard unhcr color and font in order to recognise the brand #10

Closed Edouard-Legoupil closed 1 year ago

Edouard-Legoupil commented 1 year ago

Does my code meet the quality standards for releasing packages?
Does the reviewer have all the information to validate the features/issues without too much research?
Does the customer who will validate the associated tickets have the information to do so without wasting time?

Issues to validate to close :

[ ] issue #

Checklist:

[ ] Does the package check go local?
[ ] Does the CI pass?
[ ] Are the added / fixed features documented, tested?
[ ] Are the added features / solved problems briefly presented in the PM message?
[ ] Are the changes related to tickets / issues that I have listed in the commits and in the PM itself?
[ ] Are the tickets in "review" mode in the Project Tracking Board?
[ ] Does each ticket, if it is to be closed after acceptance of the PR, contain a comment that tells how to validate it?

bluefoxr commented 1 year ago

Hi @Edouard-Legoupil thanks for working on themeing the app! I addressed the CMD errors to do with not declaring some packages (I normally use usethis::use_package() for this).

I am just wondering though if we can adjust the colours somehow as eg. the contrast between the boxes and the background is quite low, and some of the colours are a bit bright. Also can we use a different font - it looks like you were aiming for Lato but the result (at least on my PC) is Times New Roman. Do I need to install a font locally perhaps?

Edouard-Legoupil commented 1 year ago

Indeed - I agree and we can probably improve that ShinyApp theming..

Also the function used now https://github.com/UNHCR-Guatemala/A2SIT/blob/8-as-user-i-would-like-to-see-standard-unhcr-color-and-font-in-order-to-recognise-the-brand/R/theme.R comes from https://github.com/nik01010/dashboardthemes/blob/master/R/CreateTheme_shinyDashboardThemeDIY.R and is just a way to create a css

The package itself https://github.com/nik01010/dashboardthemes might be removed from CRAN -

We need to work with our designer @vidonne to get some UNHCR branded css for shinyDashboard - Will follow up with him on this!

Edouard-Legoupil commented 1 year ago

I suggest we merge this for now - will add the css later on!

bluefoxr commented 1 year ago

Ok fair enough!