UQComputingSociety / uqcsbot-discord

:mortar_board: UQCSbot: Our friendly little Discord bot
https://discord.uqcs.org
MIT License
20 stars 20 forks source link

Simplify regex in yelling.py #164

Closed bradleysigma closed 1 year ago

bradleysigma commented 1 year ago

Noticed the superfluous regex in https://www.youtube.com/live/6wFATYjMTQE?t=1376

andrewj-brown commented 1 year ago

This is honestly a little disappointing. You're a regular contributor. We have 18 open issues you could have put work into, and you yourself have an open PR needing changes (granted, unlikely to be merged anyway, for committee reasons, but still). Why are you wasting my review time and your coding time with a 3-character change? You're perfectly capable of, y'know, fulfilling the actual purpose of hacktoberfest and making positive contributions to the bot.

Hell, issue #160 is right up your alley, considering how much work you've put into the yelling cog. Why wouldn't you go do that?

If you want a concrete reason why I'm not merging this...