UQComputingSociety / uqcsbot-discord

:mortar_board: UQCSbot: Our friendly little Discord bot
https://discord.uqcs.org
MIT License
20 stars 20 forks source link

/dominoscoupons Should Use FrugalFeeds #204

Closed 49Indium closed 4 months ago

49Indium commented 5 months ago

As brought up by lucid8426 on discord, the /dominoscoupons command provides discounts that may not work. Potentially we should also include FrigralFeeds coupons.

One way to do this would be to add an optional argument for the source. I'm unsure what should happen by default: either just selecting one of the sources or trying to combine them. Ideally we would have some way to test if the coupons work, but I'm unsure if that is achievable and isn't required.

Note that we should probably still keep https://www.couponese.com/store/dominos.com.au/ in some form, as a good back-up as some of the coupons still work.

tj-dodd commented 5 months ago

I've made decent progress on this issue. The user is now able to specify whether they want a list of codes from FrugalFeeds or Couponese through an optional argument, and by default the user is provided with a combined list. Right now the combined list is a random selection of discount codes (as you end up with a pretty big list), and I'm thinking of implementing a button the user can press to refresh the combined list - although what I've got might work well enough as is.

49Indium commented 4 months ago

Completed with #205