USDA-NRCS / NRCS-Engineering-Tools---ArcGIS-Pro

Future home of the UDSA-NRCS Engineering Tools for ArcGIS Pro
GNU General Public License v3.0
3 stars 3 forks source link

Create Pool at Desired Elevation tool deleting all files in Support folder #23

Open dlhoffman opened 2 years ago

dlhoffman commented 2 years ago

The Create Pool at Desired Elevation tool under Watershed Tools > Watershed storage deletes all the files in the tools Support folder. It seemed to happen when there was already an existing layer as one that was being created. In doing some digging, it was happening when the existing layer was checked and trying to be deleted. In my local (i.e., not one on github) file (Create_Pool_At_Desired_Elevation.py), I changed the parenthesis in line 395 to brackets layersToRemove = (poolExit) to layersToRemove = [poolExit]

That seemed to resolve the issue.

CEM-NRCS commented 2 years ago

Thanks Dennis,

I'll take a look at it in the master copy. Should definitely be a list, like you've indicated.

Chris Morse USDA-NRCS State GIS Coordinator - Indiana Cell: 317-501-1578 @.**@.>

From: Dennis Hoffman @.> Sent: Wednesday, October 13, 2021 10:38 AM To: USDA-NRCS/NRCS-Engineering-Tools---ArcGIS-Pro @.> Cc: Subscribed @.***> Subject: [USDA-NRCS/NRCS-Engineering-Tools---ArcGIS-Pro] Create Pool at Desired Elevation tool deleting all files in Support folder (#23)

The Create Pool at Desired Elevation tool under Watershed Tools > Watershed storage deletes all the files in the tools Support folder. It seemed to happen when there was already an existing layer as one that was being created. In doing some digging, it was happening when the existing layer was checked and trying to be deleted. In my local (i.e., not one on github) file (Create_Pool_At_Desired_Elevation.py), I changed the parenthesis in line 395 to brackets layersToRemove = (poolExit) to layersToRemove = [poolExit]

That seemed to resolve the issue.

- You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FUSDA-NRCS%2FNRCS-Engineering-Tools---ArcGIS-Pro%2Fissues%2F23&data=04%7C01%7C%7C50517a96650e424e35e708d98e5716a9%7Ced5b36e701ee4ebc867ee03cfa0d4697%7C0%7C0%7C637697326962122931%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=1TqrJrfTp8cBqYOSRqANoJYQqpKWJmgjMj3oSaHVmxg%3D&reserved=0, or unsubscribehttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALICCIUY3YORVAR3AVLZ62DUGWKVNANCNFSM5F5LZ4AA&data=04%7C01%7C%7C50517a96650e424e35e708d98e5716a9%7Ced5b36e701ee4ebc867ee03cfa0d4697%7C0%7C0%7C637697326962132884%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Cbif2%2FUkT1ilu9pRjjhZGz3h%2FAP409r9wrUvLiQhc4M%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7C50517a96650e424e35e708d98e5716a9%7Ced5b36e701ee4ebc867ee03cfa0d4697%7C0%7C0%7C637697326962132884%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=MDGyOCImeJFqgDS29unL%2F%2BLL5J5LaLOW9RmA33eE7TY%3D&reserved=0 or Androidhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7C50517a96650e424e35e708d98e5716a9%7Ced5b36e701ee4ebc867ee03cfa0d4697%7C0%7C0%7C637697326962132884%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=rkjDNb8XyF78ZDuZgGBLFhuYh94YPAldmaFmvWst2Vo%3D&reserved=0.

This electronic message contains information generated by the USDA solely for the intended recipients. Any unauthorized interception of this message or the use or disclosure of the information it contains may violate the law and subject the violator to civil or criminal penalties. If you believe you have received this message in error, please notify the sender and delete the email immediately.