search

Ueland / VikingBot

Vikingbot is yet another simple PHP based IRC bot with support for plugins and secure IRC servers. The bot requires Unix/Linux shell access with PHP support and SSL support in PHP for use against secure IRC servers.
GNU General Public License v3.0
40 stars 6 forks source link

The whole plugin interface #25

Closed hashworks closed 9 years ago

hashworks commented 9 years ago

I'm opening this issue because of the problem in #24.

Why use an implemented interface instead of an extended class? The latter wouldn't break plugins on new features / small changes. Even if it would one could implement fallbacks. Also I see problems with the init and destroy methods - why not use construct and destruct? For example the upgradePlugins restarts the bot, but is in no way able to call the destroy methods of the bot, resulting in loss of data.

As far as Google knows there is a maximum of 5 third party plugins out there, not counting mine. I think a change resulting in breaking the external plugins once would be acceptable.

Ueland commented 9 years ago

I will not protest if you wont to change the current plugins away from interfaces to class extentions, i already merged one of your PR that caused plugin to break, so a little more wont hurt while we are at it ;)

hashworks commented 9 years ago

Alright then, I'll make a pull request in the course of the day :)