Ukendio / jecs

A fast, portable Entity Component System for Luau
https://ukendio.github.io/jecs/
MIT License
121 stars 20 forks source link

Fix types of `OnAdd`, `OnRemove` and `OnSet` #107

Closed Mark-Marks closed 1 month ago

Mark-Marks commented 1 month ago

Brief Description of your Changes.

The OnAdd, OnRemove and OnSet traits were typed as Entity<nil> leading to the type checker freaking out image

Impact of your Changes

Improved type checking

Tests Performed

Implemented exactly what was told to be implemented and how

Additional Comments

Said Entity<any> instead of Entity<nil> in commit :(