UkoeHB / monero

Monero: the secure, private, untraceable cryptocurrency
https://getmonero.org
Other
7 stars 4 forks source link

performance tests error in `test_aggregated_bulletproof_plus` #16

Closed jeffro256 closed 1 year ago

jeffro256 commented 1 year ago

On the sixth and final test_aggregated_bulletproof_plus performance test instance here, an exception is thrown with the message: sv/gamma are too large. The assertion statement can be found here, but I don't know enough about bulletproofs to debug it.

UkoeHB commented 1 year ago

Oh it only allows 16 range proofs to be aggregated, since that's the max number of outputs in ringct. At one point I was perf testing more than that (as you can see, that test is doing 32 aggregated proofs). That test can be deleted.

UkoeHB commented 1 year ago

Removed the broken tests.