search

UkoeHB / monero

Monero: the secure, private, untraceable cryptocurrency
https://getmonero.org
Other
7 stars 4 forks source link

SpTxSquashedV1: simplify txid #44

Closed jeffro256 closed 4 months ago

jeffro256 commented 4 months ago

We got rid of the tx artifacts hash. The reason for it was a follows:

note: key images are represented in the tx id twice (tx proposal prefix and input images
-    //   - the reasons are: A) decouple proposals from the enote image structure, B) don't require proposals to commit
-    //     to input commitment masks

Input proposals DO commit to input commitment masks though (see SpInputProposalCore). Does the txid hash indirection still serve a purpose or could we make the txid faster?

UkoeHB commented 4 months ago

This PR is invalid because it doesn't move commitment to K", C" into the tx proposal prefix.

Input proposals DO commit to input commitment masks though (see SpInputProposalCore). Does the txid hash indirection still serve a purpose or could we make the txid faster?

They don't commit to the masks, since proposals with different masks produce the same proposal id. I don't remember the full context around this, but more flexibility in the tx id structure is good.