search

Unity-Technologies / 2d-extras

Fun 2D Stuff that we'd like to share!
Other
1.54k stars 342 forks source link

-Add LayerBrush which edits all Tilemaps sharing the same Grid #257

Open marcus-robinson opened 3 years ago

marcus-robinson commented 3 years ago

Please add layer brush to master branch and include in the next release.

ChuanXin-Unity commented 3 years ago

Hi, we would like to work on this feature a little more before adding it for release. If you could share some suggestions on how you would like to use this feature or improve it, do let us know! Thanks!

marcus-robinson commented 3 years ago

@ChuanXin-Unity I'm using the LayerBrush to move around entire areas of my grid - multiple layers of tiles that form a scene. This is a crucial use case for anyone building out large levels with tilemaps. It's working just fine in its current form for my use case, which is why I raised the PR, since right now, I have to copy/paste the brush file into the 1.5.0-preview release which is inconvenient.

ChuanXin-Unity commented 3 years ago

Thanks for the feedback! We will work on getting it into master and into the main package.

In the meantime, you could add this file and its corresponding metafile directly into your project to use it while using the package directly. Mixing and matching the scripts is possible as long as there are no duplicates between the project and the package.

brogan89 commented 3 years ago

I second this. It's a very useful feature. I merged it into master fine in my fork, then you can keep up to date with other features as well.

One feature that might be handy is having it toggle on with a shortcut key i.e from the default brush holding down ctrl or something to use the Layer Bush. Mainly because sometimes I forget I'm using that brush and I end up painting tiles into wrong layers etc. But that could just be me.

ChuanXin-Unity commented 3 years ago

Thanks for the comment! If you have any other suggestions or feedback on the Layer Brush, do let us know about it!

GitFlip commented 2 years ago

Thanks for the comment! If you have any other suggestions or feedback on the Layer Brush, do let us know about it!

This PR has been opened for over two years. Is there a status on what's preventing it from being merged into master?

ChuanXin-Unity commented 2 years ago

@GitFlip For a new feature to go in, it has to be validated by the various stakeholders within Unity. For example, a product manager would like to validate that this is a viable product for users to use; a UX designer will need to check if the user experience is right, etc. So far, this has not been approved by these stakeholders as viable, but having feedback from you and other users can help bring prominence to the stakeholders for approval.

GitFlip commented 1 year ago

@GitFlip For a new feature to go in, it has to be validated by the various stakeholders within Unity. For example, a product manager would like to validate that this is a viable product for users to use; a UX designer will need to check if the user experience is right, etc. So far, this has not been approved by these stakeholders as viable, but having feedback from you and other users can help bring prominence to the stakeholders for approval.

I appreciate this response a lot. Any chance you can provide details on why it's not viable? What updates are required? Can you leverage on the community more then to make this viable? I think it's just not clear to us what we can do to help.

ChuanXin-Unity commented 1 year ago

Hi, what we would like most of confirmation of whether this Brush works for most users and contains all of the features necessary to make it work. If you could share how you are using it and any improvements that can be made for it, it could help make the case for it for the key decision-makers, and would be very much appreciated. Thanks!

On Fri, Oct 14, 2022, 08:59 Rob Filippi @.***> wrote:

@GitFlip https://github.com/GitFlip For a new feature to go in, it has to be validated by the various stakeholders within Unity. For example, a product manager would like to validate that this is a viable product for users to use; a UX designer will need to check if the user experience is right, etc. So far, this has not been approved by these stakeholders as viable, but having feedback from you and other users can help bring prominence to the stakeholders for approval.

I appreciate this response a lot. Any chance you can provide details on why it's not viable? What updates are required? Can you leverage on the community more then to make this viable? I think it's just not clear to us what we can do to help.

— Reply to this email directly, view it on GitHub https://github.com/Unity-Technologies/2d-extras/pull/257#issuecomment-1278297534, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHA3TETMCN3RUX7IDKFV473WDCO43ANCNFSM4VE6V5ZA . You are receiving this because you were mentioned.Message ID: @.***>

alipha commented 1 year ago

I also find this layer brush very useful. For instance, I'm working on a top-down 2d rpg and am creating buildings for a town. A building is composed of multiple layers (at least 3). Now, if I decide I think the building would look better at a different location, I have to move each layer one at a time. With this brush, I can move all the layers which compose this house at the same time.